Try to fix deprecation of NSUserNotification#2876
Try to fix deprecation of NSUserNotification#2876Luflosi wants to merge 1 commit intokovidgoyal:masterfrom
Conversation
|
Oh for fuck's sake more of Apple's silly users need to be protected from I will look into this someday, when the only alternative is gouging out |
|
@Luflosi just to clarify, do you have any problems with this PR? |
|
Do you mean that you can get a notification to display? In my testing it didn't work. It does compile without warnings though. |
1 similar comment
|
Do you mean that you can get a notification to display? In my testing it didn't work. It does compile without warnings though. |
|
negative. no notification - haven't tested it, cause I am not needing them for terminal ... also don't need update notifications I had a look, it seems alright. Might be issue with privacy. For notifications to work, you need pop-up asking user for permission, which I am a fan of! sorry |
|
I tried implementing this, after wasting eight hours of my life on it. I find that at least on Catalina permission for notifications is always denied, so this entire exercise is pointless. Read the commit message for details. If i missed something and someone can get this to work, patches welcome. In the meantime I am just going to turn of Werror for cocoa_window.m |
|
Would you accept a PR that makes it possible to select the old API with a compile-time option? |
|
Since the API is deprecated it will presumably be removed by Apple, at |
Here is an unfinished and not actually working commit that's supposed to fix the deprecation issue mentioned in #2805. Maybe you find it useful to develop actually working code.